Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix fallback for 'Visit site' link when repo.website is missing #802

Merged
merged 2 commits into from
Aug 22, 2024
Merged

Fix fallback for 'Visit site' link when repo.website is missing #802

merged 2 commits into from
Aug 22, 2024

Conversation

Clemo97
Copy link
Contributor

@Clemo97 Clemo97 commented Aug 10, 2024 •
edited
Loading

Fixes

The fallback URL for Visit site would redirect user back to home page when the website link doesn't exist.

Description

The PR adds an or parameter in the Visit site redirect {{ repo.website or repo.url }} , that way if the website URL is non-existent it falls back to the github repo URL.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin 
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@Clemo97 Clemo97 requested review from a team as code owners August 10, 2024 13:22
@Clemo97 Clemo97 requested review from Shafiya-Heena, possumbilities and akmadian and removed request for a team August 10, 2024 13:22
@naishasinha
Copy link
Member

Looks good!
@TimidRobot

@TimidRobot
Copy link
Member

@Clemo97 please mark the appropriate items in the Checklist of the pull request description

@TimidRobot TimidRobot self-assigned this Aug 11, 2024
@Clemo97
Copy link
Contributor Author

Clemo97 commented Aug 12, 2024

@Clemo97 please mark the appropriate items in the Checklist of the pull request description

Noted and done @TimidRobot. I've also fixed the spacing issue repo.website or repo.url

TimidRobot
TimidRobot approved these changes Aug 22, 2024
View reviewed changes
Copy link
Member

@TimidRobot TimidRobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! thank you!!

@TimidRobot TimidRobot merged commit 7cff756 into creativecommons:main Aug 22, 2024
1 check passed
@Clemo97
Copy link
Contributor Author

Clemo97 commented Aug 22, 2024 •
edited
Loading

nice! thank you!!

Your welcome, @naishasinha and @TimidRobot are there any more tough and challenging issues within creative commons that need solving?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimidRobot TimidRobot TimidRobot approved these changes

@Shafiya-Heena Shafiya-Heena Awaiting requested review from Shafiya-Heena Shafiya-Heena is a code owner automatically assigned from creativecommons/technology

@possumbilities possumbilities Awaiting requested review from possumbilities possumbilities is a code owner automatically assigned from creativecommons/technology

@akmadian akmadian Awaiting requested review from akmadian akmadian is a code owner automatically assigned from creativecommons/ct-cc-open-source-core-committers

Assignees

@TimidRobot TimidRobot

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Fix Broken Link in Featured Projects Section
3 participants
@Clemo97 @naishasinha @TimidRobot